Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

5.3 release branch #730

Merged
merged 30 commits into from
Apr 9, 2021
Merged

5.3 release branch #730

merged 30 commits into from
Apr 9, 2021

Conversation

jaapbrasser
Copy link
Contributor

@jaapbrasser jaapbrasser commented Mar 8, 2021

Description

Adding in a number of changes of in order to prepare for the 5.3 release of the module.

Related Issue

This project only accepts pull requests related to open issues.

Resolves #742
Resolves #736
Resolves #733
Resolves #732
Resolves #722

How Has This Been Tested?

  • New unit tests have been added and old unit tests run successfully

Screenshots (if appropriate):

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

Go over all the following points, and put an x in all the boxes that apply. If you're unsure about any of these, don't hesitate to ask. We're here to help!

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTION document.
  • I have updated the CHANGELOG file accordingly for the version that this merge modifies.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@jaapbrasser jaapbrasser marked this pull request as ready for review April 8, 2021 21:12
@jaapbrasser jaapbrasser requested a review from mwpreston April 8, 2021 21:17
@jaapbrasser jaapbrasser self-assigned this Apr 8, 2021
Copy link
Contributor

@mwpreston mwpreston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another amazing release @jaapbrasser !!! Good work!

I added a couple things to the new Debug cmdlet (module options and default parameters) as well as updated some help wording... Other than that, LGTM!

@jaapbrasser jaapbrasser merged commit 0037b64 into devel Apr 9, 2021
@jaapbrasser jaapbrasser deleted the jaap-53release branch April 9, 2021 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment