Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated API data and Event/Eventseries cmdlets for 5.2 compatibility #684

Merged
merged 17 commits into from
Sep 8, 2020

Conversation

jaapbrasser
Copy link
Contributor

@jaapbrasser jaapbrasser commented Sep 3, 2020

Description

Current Behavior:

The endpoint used to query events has changed in 5.2. It now resides in /v1/events rather than /internal/events

Related Issue

Resolves #626
Resolves #686
Resolves #439

Motivation and Context

The endpoint used to query events has changed in 5.2. It now resides in /v1/events rather than /internal/events

How Has This Been Tested?

  • New unit tests have been created, existing ones pass

Screenshots (if appropriate):

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

Go over all the following points, and put an x in all the boxes that apply. If you're unsure about any of these, don't hesitate to ask. We're here to help!

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTION document.
  • I have updated the CHANGELOG file accordingly for the version that this merge modifies.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@jaapbrasser jaapbrasser marked this pull request as ready for review September 5, 2020 14:25
Copy link
Contributor

@shamsway shamsway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful work

@shamsway shamsway merged commit 4cc1d0a into devel Sep 8, 2020
@shamsway shamsway deleted the jaap-626 branch September 8, 2020 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants