Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added structured output to Get-RubrikReportData - #549 #635

Merged
merged 6 commits into from
Jun 8, 2020
Merged

Conversation

jaapbrasser
Copy link
Contributor

Description

Is your feature request related to a problem? Please describe.

No. Currently when running Get-RubrikReportData with the reporting ID, it returns a valid response, however, Rubrik Reporting keeps the Column names separated to the actual data, meaning when you loop through the dataGrid object, you are unable to correlate the columns.

It's difficult for users of the SDK to easily handle reporting data. For example:

Related Issue

Resolves #549

Motivation and Context

Adds structured output, makes it easier to filter and process output of this cmdlet

How Has This Been Tested?

Existing tests pass, new test added

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

Go over all the following points, and put an x in all the boxes that apply. If you're unsure about any of these, don't hesitate to ask. We're here to help!

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTION document.
  • I have updated the CHANGELOG file accordingly for the version that this merge modifies.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@jaapbrasser jaapbrasser requested review from mwpreston and shamsway May 24, 2020 20:03
Copy link
Contributor

@mwpreston mwpreston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes things so much easier to read! Good Job @jaapbrasser

@mwpreston mwpreston merged commit eb634ce into devel Jun 8, 2020
@jaapbrasser jaapbrasser deleted the jaap-549 branch July 16, 2021 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Get-RubrikReportData Requires Overhaul
2 participants