Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to how Disconnect-Rubrik handles variable cleanup #599

Merged
merged 4 commits into from
Apr 1, 2020
Merged

Conversation

jaapbrasser
Copy link
Contributor

Description

Current Behavior:

When Disconnect-Rubrik is ran, depending on what method of connection is used, either

Expected Behavior:

Steps to Reproduce:

Please provide detailed steps for reproducing the issue.

Connect-Rubrik -Credential $Cred
Disconnect-Rubrik

$RubrikConnection & $RubrikConnections are not cleared

Context:

All versions of PowerShell & Windows PowerShell are affected

Related Issue

Resolve #598

Motivation and Context

Fix inconsistency in how $RubrikConnection(s) variables are cleaned up

How Has This Been Tested?

Ran current unit tests and created new unit tests to cover the changes

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

Go over all the following points, and put an x in all the boxes that apply. If you're unsure about any of these, don't hesitate to ask. We're here to help!

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTION document.
  • I have updated the CHANGELOG file accordingly for the version that this merge modifies.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@jaapbrasser jaapbrasser changed the title Jaap 598 Changes to how Disconnect-Rubrik handles variable cleanup Mar 31, 2020
@jaapbrasser jaapbrasser requested a review from mwpreston March 31, 2020 20:13
Copy link
Contributor

@mwpreston mwpreston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mwpreston mwpreston merged commit 17c5209 into devel Apr 1, 2020
@mwpreston mwpreston deleted the jaap-598 branch April 1, 2020 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disconnect-Rubrik does not clear values in $RubrikConnections
2 participants