-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 580 - Get-RubrikEventSeries #585
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, from a functionality point of view I tested this against both 5.0 and 5.1. It seems that when querying by eventseriesid the objects look slightly different than when querying by eventtype.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes - output is slightly different. This is due to what the api endpoints return and how they function. IE - querying by an eventSeriesId calls Querying by status or eventType calls the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Description
Changed
Get-RubrikEvent
, adding parametersets to isolate eventSeriesId. When cmdlet is called with eventSeriesId theGet-RubrikEventSeries
cmdlet is now called rather than filtering through a giant, unindexed table. Details in Issue 580 and updated unit tests.Related Issue
Issue 580
Motivation and Context
When using the eventSeriesId parameter on Get-RubrikEvent it will now call Get-RubrikEventSeries which in turn calls the API which utilizes the properly indexed table to retrieve events based on eventSeries.
How Has This Been Tested?
Tested against 5.0 and 5.1 in the TM lab
Screenshots (if appropriate):
Types of changes
What types of changes does your code introduce? Put an
x
in all the boxes that apply:Checklist:
Go over all the following points, and put an
x
in all the boxes that apply. If you're unsure about any of these, don't hesitate to ask. We're here to help!