Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address issues 535, 536, and 537 #538

Merged
merged 2 commits into from
Jan 3, 2020
Merged

Address issues 535, 536, and 537 #538

merged 2 commits into from
Jan 3, 2020

Conversation

shamsway
Copy link
Contributor

Description

Related Issue

Resolves #535
Resolves #536
Resolves #537

How Has This Been Tested?

Tested via manual tests and unit tests

Screenshots (if appropriate):

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

Go over all the following points, and put an x in all the boxes that apply. If you're unsure about any of these, don't hesitate to ask. We're here to help!

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTION document.
  • I have updated the CHANGELOG file accordingly for the version that this merge modifies.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@shamsway shamsway requested a review from mwpreston December 19, 2019 22:36
Copy link
Contributor

@mwpreston mwpreston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @shamsway - Thanks!

@mwpreston mwpreston merged commit 826573b into devel Jan 3, 2020
@jaapbrasser jaapbrasser deleted the melliott-535 branch April 22, 2020 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants