Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated bool to switch and made function names singular nouns - Issue 326 and 509 #510

Merged
merged 18 commits into from
Nov 6, 2019

Conversation

jaapbrasser
Copy link
Contributor

@jaapbrasser jaapbrasser commented Nov 5, 2019

Description

Please describe your pull request in detail.

Related Issue

Resolve #326
Resolve #509

Motivation and Context

Consistency in the SDK

How Has This Been Tested?

Tested against the TME Cluster

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

Go over all the following points, and put an x in all the boxes that apply. If you're unsure about any of these, don't hesitate to ask. We're here to help!

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTION document.
  • I have updated the CHANGELOG file accordingly for the version that this merge modifies.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@jaapbrasser jaapbrasser requested a review from shamsway November 5, 2019 22:30
@jaapbrasser
Copy link
Contributor Author

Ready for review @shamsway

Copy link
Contributor

@shamsway shamsway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm so embarrassed 😳

@shamsway shamsway merged commit 11f87ad into devel Nov 6, 2019
@shamsway shamsway deleted the jaap-326 branch November 6, 2019 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some of the vApp functions have a plural noun
2 participants