Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 487 - Expose volume letter in "Get-RubrikVolumeGroup" #492

Merged
merged 19 commits into from
Nov 1, 2019

Conversation

jaapbrasser
Copy link
Contributor

Description

Add the associated protected volume letter to a VolumeGroup ID in the Get-RubrikVolumeGroup CMDlet

Related Issue

Resolve #487

Motivation and Context

The default display does not display any associated volumes, this is the default in the GUI interface and would be interesting data to display. In order to resolve this I have done the following:

  • Added -DetailedObject parameter, as is present in other Get-Rubrik* functions
  • Updated documentation
  • Updated default display to in the 'includes' field

How Has This Been Tested?

Existing unit tests run, new unit tests have been created. Ran the code against the TME test clusters.

Screenshots (if appropriate):

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

Go over all the following points, and put an x in all the boxes that apply. If you're unsure about any of these, don't hesitate to ask. We're here to help!

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTION document.
  • I have updated the CHANGELOG file accordingly for the version that this merge modifies.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@jaapbrasser
Copy link
Contributor Author

No review required yet, working out some issues with this at the moment

@jaapbrasser
Copy link
Contributor Author

Ready for review

shamsway
shamsway previously approved these changes Oct 30, 2019
Copy link
Contributor

@shamsway shamsway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested against CDM 5.0.2 - working as expected

There are some failing unit tests for Get-RubrikVolumeGroup.Tests.ps1, but this may be a false positive

@jaapbrasser
Copy link
Contributor Author

Interesting, yea seems the Windows PowerShell tests behave differently from the PowerShell unit tests, I'll resolve this before we can merge
image

@jaapbrasser
Copy link
Contributor Author

@shamsway resolved issues and resubmitted for review

Copy link
Contributor

@mwpreston mwpreston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @jaapbrasser .

Submit-Requests tests are failing when run in core - but that's happening with my current branch as well so unrelated :)

@jaapbrasser jaapbrasser merged commit 4b386f3 into devel Nov 1, 2019
@jaapbrasser jaapbrasser deleted the jaap-487 branch November 1, 2019 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expose volume letter in "Get-RubrikVolumeGroup"
3 participants