-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 487 - Expose volume letter in "Get-RubrikVolumeGroup" #492
Conversation
No review required yet, working out some issues with this at the moment |
Ready for review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested against CDM 5.0.2 - working as expected
There are some failing unit tests for Get-RubrikVolumeGroup.Tests.ps1, but this may be a false positive
@shamsway resolved issues and resubmitted for review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good @jaapbrasser .
Submit-Requests tests are failing when run in core - but that's happening with my current branch as well so unrelated :)
Description
Add the associated protected volume letter to a VolumeGroup ID in the Get-RubrikVolumeGroup CMDlet
Related Issue
Resolve #487
Motivation and Context
The default display does not display any associated volumes, this is the default in the GUI interface and would be interesting data to display. In order to resolve this I have done the following:
How Has This Been Tested?
Existing unit tests run, new unit tests have been created. Ran the code against the TME test clusters.
Screenshots (if appropriate):
Types of changes
What types of changes does your code introduce? Put an
x
in all the boxes that apply:Checklist:
Go over all the following points, and put an
x
in all the boxes that apply. If you're unsure about any of these, don't hesitate to ask. We're here to help!