Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed -Verbose incomplete message - Issue #480 #482

Merged
merged 6 commits into from
Oct 28, 2019
Merged

Fixed -Verbose incomplete message - Issue #480 #482

merged 6 commits into from
Oct 28, 2019

Conversation

jaapbrasser
Copy link
Contributor

Description

This is a super minor issue, and I stumbled across this by accident.

When running a cmdlet with the -verbose switch, messages are being returned back without the function name in the "Load API Data for " statement

See the line in bold below.
I have found this to be true with all cmdlets in the module.

The reason for this is that in Get-RubrikAPIData, each cmdlet definition is missing the "Function" Key and value.

Depending on when this gets looked at, Get-RubrikDatabase, may have been fixed as a my last update to the module corrected this issue for that cmdlet. However, other cmdlets will have the same issue.
Provide information about the failure by issuing the command using the -Verbose command.

Related Issue

Resolve #480

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

Go over all the following points, and put an x in all the boxes that apply. If you're unsure about any of these, don't hesitate to ask. We're here to help!

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTION document.
  • I have updated the CHANGELOG file accordingly for the version that this merge modifies.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@jaapbrasser
Copy link
Contributor Author

Hi Mike & Matt,

I ran the first pull request against the new pipeline with issue #480, let me know how the changes look and feel free to merge if it looks good.

Also resolve a minor yml bug where I used " instead of '

Copy link
Contributor

@mwpreston mwpreston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @jaapbrasser

With more cmdlets now calling other cmdlets this will certainly help with debugging :)

@mwpreston mwpreston merged commit 8276a41 into devel Oct 28, 2019
@jaapbrasser jaapbrasser deleted the jaap-480 branch November 4, 2019 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

-Verbose returns back incomplete messages.
2 participants