-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial commit of vCD cmdlets and related tests #453
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've looked over code and made some changes listed below. That said, I'll let @rfitzhugh validate the actual functionality as I feel like I could possibly break something :)
- Added some code around the Relic switch
- Also removed -Depth from some of the ConvertFrom-JSON statements in the tests as that param wasn't available pre PowerShell 6.
- Changed some tests which referenced .length to use .count as it was evaluating to null when only one result was returned.
- All tests passing now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made some small documentation changes, otherwise LGTM.
@@ -0,0 +1,96 @@ | |||
#requires -Version 3 | |||
function Get-RubrikVcdTemplateExportOptions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it intentional that you use Vcd
when referencing templates but VCD
when referencing the server?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally I try to use vCD in documentation or anything that is not actual code. Within CDM Vcd
is typically used in object IDs and other places. Cmdlet names typically use UpperCamelCase, so I will do a quick pass and make sure there is consistency, at very least.
@shamsway I left one comment. Once conflicts are addressed, should be good to merge. |
…eExportOptions.ps1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed and approved, ship it!
Description
initial support for VMware vCloud Director (vCD) API endpoints in CDM
Update-RubrikVCD
,Set-RubrikVCD
,Restore-RubrikVApp
,Protect-RubrikVApp
,Get-RubrikVcdTemplateExportOptions
,Get-RubrikVCD
,Get-RubrikVappSnapshot
,RubrikVAppRecoverOptions
,Get-RubrikVAppExportOptions
,Get-RubrikVApp
,Export-RubrikVcdTemplate
,Export-RubrikVApp
and related tests as requested in Issue 273Get-RubrikSnapshot
to support vCD vAppsRelated Issue
#273
Motivation and Context
Why is this change required? What problem does it solve? Add new functionality to SDK
How Has This Been Tested?
Types of changes
What types of changes does your code introduce? Put an
x
in all the boxes that apply:Checklist:
Go over all the following points, and put an
x
in all the boxes that apply. If you're unsure about any of these, don't hesitate to ask. We're here to help!