Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial commit of vCD cmdlets and related tests #453

Merged
merged 42 commits into from
Sep 26, 2019
Merged

Conversation

shamsway
Copy link
Contributor

@shamsway shamsway commented Sep 19, 2019

Description

initial support for VMware vCloud Director (vCD) API endpoints in CDM

  • Added cmdlets Update-RubrikVCD, Set-RubrikVCD, Restore-RubrikVApp, Protect-RubrikVApp, Get-RubrikVcdTemplateExportOptions, Get-RubrikVCD, Get-RubrikVappSnapshot, RubrikVAppRecoverOptions, Get-RubrikVAppExportOptions, Get-RubrikVApp, Export-RubrikVcdTemplate, Export-RubrikVApp and related tests as requested in Issue 273
  • Updated Get-RubrikSnapshot to support vCD vApps
  • Misc bug fixes and typos corrected

Related Issue

#273

Motivation and Context

Why is this change required? What problem does it solve? Add new functionality to SDK

How Has This Been Tested?

  • Extensive manual testing from macOS against CDM 5.0 and 5.1EA and vCD 9.5
  • Unit tests added

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

Go over all the following points, and put an x in all the boxes that apply. If you're unsure about any of these, don't hesitate to ask. We're here to help!

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTION document.
  • I have updated the CHANGELOG file accordingly for the version that this merge modifies.
  • I have added tests to cover my changes.
  • All new and existing tests passed. Tests passing when run locally, but failing on AppVeyor

@shamsway shamsway changed the title Melliott 273 Initial commit of vCD cmdlets and related tests Sep 20, 2019
@shamsway shamsway marked this pull request as ready for review September 20, 2019 00:44
mwpreston
mwpreston previously approved these changes Sep 24, 2019
Copy link
Contributor

@mwpreston mwpreston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've looked over code and made some changes listed below. That said, I'll let @rfitzhugh validate the actual functionality as I feel like I could possibly break something :)

  • Added some code around the Relic switch
  • Also removed -Depth from some of the ConvertFrom-JSON statements in the tests as that param wasn't available pre PowerShell 6.
  • Changed some tests which referenced .length to use .count as it was evaluating to null when only one result was returned.
  • All tests passing now

rfitzhugh
rfitzhugh previously approved these changes Sep 26, 2019
Copy link
Contributor

@rfitzhugh rfitzhugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made some small documentation changes, otherwise LGTM.

@@ -0,0 +1,96 @@
#requires -Version 3
function Get-RubrikVcdTemplateExportOptions
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it intentional that you use Vcd when referencing templates but VCD when referencing the server?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally I try to use vCD in documentation or anything that is not actual code. Within CDM Vcd is typically used in object IDs and other places. Cmdlet names typically use UpperCamelCase, so I will do a quick pass and make sure there is consistency, at very least.

@rfitzhugh
Copy link
Contributor

@shamsway I left one comment. Once conflicts are addressed, should be good to merge.

Copy link
Contributor

@jaapbrasser jaapbrasser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed and approved, ship it!

@shamsway shamsway merged commit b1da929 into master Sep 26, 2019
@shamsway shamsway deleted the melliott-273 branch September 26, 2019 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants