Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce parameter sets for Get-RubrikManagedVolume - Issue 351 #423

Merged
merged 15 commits into from
Aug 12, 2019

Conversation

jaapbrasser
Copy link
Contributor

Description

Currently there are no parameter sets, or parameter validation implemented.

Related Issue

Resolve #351

Motivation and Context

Currently there are no parameter sets, or parameter validation implemented. I would like to have different parameter sets for id and name, as they should not be specified at the same time. Currently id is the default parameter, I feel it would make more sense to make Name the default parameter.

How Has This Been Tested?

  • Tested against TME Test clusters
  • Ran unit tests
  • Created new unit tests

Screenshots (if appropriate):

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

Go over all the following points, and put an x in all the boxes that apply. If you're unsure about any of these, don't hesitate to ask. We're here to help!

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTION document.
  • I have updated the CHANGELOG file accordingly for the version that this merge modifies.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

shamsway
shamsway previously approved these changes Aug 12, 2019
Copy link
Contributor

@shamsway shamsway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested - looks good

Copy link
Contributor

@shamsway shamsway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@shamsway shamsway merged commit ae2d030 into master Aug 12, 2019
@shamsway shamsway deleted the jaap-351 branch August 12, 2019 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Introduce parameter sets for Get-RubrikManagedVolume
2 participants