Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with Get-RubrikSQLInstance and documentation update - Issue #399 #413

Merged
merged 4 commits into from
Jul 31, 2019

Conversation

jaapbrasser
Copy link
Contributor

Description

Provide information about the failure by issuing the command using the -Verbose command.

  • Get-RubrikSQLInstance seems to ignore the local value for PrimaryClusterID
    From what I have seen, running Get-RubrikSQLInstance to pull back all SQL Instances gets all instances including instances on a remote Rubrik Cluster. Using the local flag should exclude all instances from a remote rubrik cluster.
  • Help text is incorrect in the value it should use for PrimaryClusterID. It states you should use _local, when the value should be local

Related Issue

Resolve #399

Motivation and Context

Bug in the Get-RubrikSQLInstance function

How Has This Been Tested?

By running local tests and testing against TM test clusters

Screenshots (if appropriate):

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

Go over all the following points, and put an x in all the boxes that apply. If you're unsure about any of these, don't hesitate to ask. We're here to help!

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTION document.
  • I have updated the CHANGELOG file accordingly for the version that this merge modifies.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@jaapbrasser jaapbrasser self-assigned this Jul 31, 2019
@jaapbrasser jaapbrasser changed the title Jaap 399 Issue with Get-RubrikSQLInstance and documentation update - Issue #399 Jul 31, 2019
Copy link
Contributor

@shamsway shamsway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@shamsway shamsway merged commit 129b964 into master Jul 31, 2019
@shamsway shamsway deleted the jaap-399 branch July 31, 2019 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Get-RubrikSQLInstance seems to ignore the local value for PrimaryClusterID
2 participants