Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Token validation for Connect-Rubrik - Issue 374 #380

Merged
merged 8 commits into from
Jul 16, 2019
Merged

Conversation

jaapbrasser
Copy link
Contributor

Description

The Connect-Rubrik function does not validate token validity

Related Issue

#374

Motivation and Context

Expect the Connect-Rubrik function to fail if an invalid token or expired token is used

How Has This Been Tested?

Tested against different Rubrik Cluster versions on PowerShell 5 and 6

Screenshots (if appropriate):

image

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

Go over all the following points, and put an x in all the boxes that apply. If you're unsure about any of these, don't hesitate to ask. We're here to help!

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTION document.
  • I have updated the CHANGELOG file accordingly for the version that this merge modifies.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@jaapbrasser
Copy link
Contributor Author

Branched off incorrect, please review #377 before reviewing this PR as this contains some of the commits of that branch.

shamsway
shamsway previously approved these changes Jul 16, 2019
Copy link
Contributor

@shamsway shamsway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed #377 / #379 beforehand. All looks good.

@shamsway shamsway merged commit b9813ec into master Jul 16, 2019
@shamsway shamsway deleted the jaap-374 branch July 16, 2019 02:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants