-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New API Token cmdlets #317
Conversation
Signed-off-by: Chris Wahl <[email protected]>
Signed-off-by: Chris Wahl <[email protected]>
Signed-off-by: Chris Wahl <[email protected]>
Signed-off-by: Chris Wahl <[email protected]>
Signed-off-by: Chris Wahl <[email protected]>
Signed-off-by: Chris Wahl <[email protected]>
This cmdlet is only supported in 5.0 (new feature). Because of this, it appears that Pester tests for the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jaapbrasser - I'm not sure if we can exclude different api version from the pester tests on the Get-RubrikAPIData cmdlet? Either way, other than that this code looks good to me... I'll leave the merge to you :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed, looks good thanks for the work here @chriswahl & @mwpreston
Description
I would like to be able to programmatically request a new API Token as part of an automated workflow for token rotation.
Related Issue
Fixes #316
Motivation and Context
Even though a user can generate a new API Token using the GUI, there exists the need to rotate those tokens on a regular basis. This can be done through regular expiration / creation cycles, or by forcing an expiration of a token arbitrarily and creating a new token on demand.
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
What types of changes does your code introduce? Put an
x
in all the boxes that apply:Checklist:
Go over all the following points, and put an
x
in all the boxes that apply. If you're unsure about any of these, don't hesitate to ask. We're here to help!