Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Remove-RubrikVMSnapshot cmdlet and additional logging #308

Merged
merged 8 commits into from
Jun 21, 2019

Conversation

shamsway
Copy link
Contributor

Description

This PR adds a new Remove-RubrikVMSnapshot cmdlet and associated unit test, along with some additional verbose logging. It also modifies the logic so that DELETE API calls return a response when the API call is successful. Previously the user was given no response in this scenario.

Related Issue

This project only accepts pull requests related to open issues.

  • If suggesting a new feature or change, please discuss it in an issue first.
  • If fixing a bug, there should be an issue describing it with steps to reproduce

#148

Motivation and Context

Why is this change required? What problem does it solve?

This PR addresses #148, and it provides additional useful output to the user

How Has This Been Tested?

  • Please describe in detail how you tested your changes.
  • Include details of your testing environment, and the tests you ran to see how your change affects other areas of the code, etc.

Tested against CDM 5.0.1 from MacOS. I tested almost all of the Remove-* cmdlets to verify the new response would not affect them, and tested several Get-* cmdlets as a smoke test to verify that the code needed for additional verbose logging did not have unintentional effects.

Screenshots (if appropriate):

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

Go over all the following points, and put an x in all the boxes that apply. If you're unsure about any of these, don't hesitate to ask. We're here to help!

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTION document.
  • I have updated the CHANGELOG file accordingly for the version that this merge modifies.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link
Contributor

@mwpreston mwpreston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks great to me - I will reassign to Jaap for final call. Good job!

@mwpreston mwpreston requested review from jaapbrasser and removed request for jaapbrasser June 21, 2019 14:07
jaapbrasser
jaapbrasser previously approved these changes Jun 21, 2019
Copy link
Contributor

@jaapbrasser jaapbrasser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @shamsway, thanks for the last minute changes

Copy link
Contributor

@jaapbrasser jaapbrasser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jaapbrasser
Copy link
Contributor

Resolve #148

@jaapbrasser jaapbrasser merged commit c57ec0f into master Jun 21, 2019
@shamsway shamsway deleted the melliott-devel-148 branch June 21, 2019 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants