Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Get-RubrikOrganization to address issue 224 #293

Merged
merged 5 commits into from
May 27, 2019

Conversation

shamsway
Copy link
Contributor

Description

This PR changes the behavior of GetRubrikOrganization so it will only return an exact match when using the -Name parameter. Previously it would return any substring match.

Related Issue

This project only accepts pull requests related to open issues.

  • If suggesting a new feature or change, please discuss it in an issue first.
  • If fixing a bug, there should be an issue describing it with steps to reproduce

#224

Motivation and Context

Why is this change required? What problem does it solve? This changes Get-RubrikOrganization so it's behavior matches that of Get-RubrikVM and other similar functions

How Has This Been Tested?

  • Please describe in detail how you tested your changes.
  • Include details of your testing environment, and the tests you ran to see how your change affects other areas of the code, etc.

Tested against Rubrik CDM 4.2.2 and 5.0

Screenshots (if appropriate):

image
Cluster has organizations test, test1 and test2. Previously Get-RubrikOrganization would return all three.

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

Go over all the following points, and put an x in all the boxes that apply. If you're unsure about any of these, don't hesitate to ask. We're here to help!

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTION document.
  • I have updated the CHANGELOG file accordingly for the version that this merge modifies.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@jaapbrasser
Copy link
Contributor

Thanks for your contribution Matt, I'll review the changes you've made as soon as possible.

jaapbrasser
jaapbrasser previously approved these changes May 27, 2019
Copy link
Contributor

@jaapbrasser jaapbrasser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on Lab environment, change works as expected. Great work @shamsway!

@jaapbrasser
Copy link
Contributor

Resolve #224, thanks for the contribution @shamsway

Copy link
Contributor

@jaapbrasser jaapbrasser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed merge conflicts and updated, reviewed.

@jaapbrasser jaapbrasser merged commit 168d454 into master May 27, 2019
@jaapbrasser jaapbrasser deleted the melliott-devel-224 branch May 27, 2019 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants