Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Oracle Database support in Rubrik SDK for PowerShell #266

Merged
merged 16 commits into from
Jun 26, 2019
Merged

Conversation

jaapbrasser
Copy link
Contributor

Description

@DamaniN requested support for Oracle DBs in the Rubrik PowerShell Module

Related Issue

#255

Motivation and Context

It add additional functionality

How Has This Been Tested?

Ran this against the TME Lab Cluster 5.0.0

Screenshots (if appropriate):

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

Go over all the following points, and put an x in all the boxes that apply. If you're unsure about any of these, don't hesitate to ask. We're here to help!

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTION document.
  • I have updated the CHANGELOG file accordingly for the version that this merge modifies.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@jaapbrasser
Copy link
Contributor Author

No review required as of yet, I put the PR up so @DamaniN can review the code and report his findings. Additional tests will be added as well

@chriswahl chriswahl requested review from chriswahl and removed request for chriswahl March 28, 2019 13:28
mwpreston
mwpreston previously approved these changes Jun 26, 2019
Copy link
Contributor

@mwpreston mwpreston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything working as expected.

Added a few commits around providing Oracle support in New-RubrikSnapshot along with associated tests.

Copy link
Contributor

@mwpreston mwpreston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

resolved merge conflicts in changelog

@mwpreston mwpreston merged commit f5d8355 into master Jun 26, 2019
@mwpreston mwpreston deleted the jaapjaap-dev branch June 26, 2019 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants