Use permitted in line_length.rb #6464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this is easier to understand and better terminology
This was referenced Nov 10, 2018
8 tasks
koic
added a commit
to koic/rubocop
that referenced
this pull request
Nov 3, 2019
### Summary Follow up rubocop#6464, rubocop#6466, and rubocop#6467. This PR changes a terminology from `Whitelist` and `Blacklist` to `Allowlist` and `Denylist`. This change is an obvious breaking change to some cop options. So I'd like to introduce it before RuboCop 1.0 if this change is acceptable. ### Other Information This change has also been made in Rails repository and other repos. rails/rails#33681
bbatsov
pushed a commit
that referenced
this pull request
Nov 5, 2019
### Summary Follow up #6464, #6466, and #6467. This PR changes a terminology from `Whitelist` and `Blacklist` to `Allowlist` and `Denylist`. This change is an obvious breaking change to some cop options. So I'd like to introduce it before RuboCop 1.0 if this change is acceptable. ### Other Information This change has also been made in Rails repository and other repos. rails/rails#33681
grantbdev
added a commit
to grantbdev/carrierwave
that referenced
this pull request
Dec 17, 2019
Add public interface alternative to whitelist so users who prefer not to use that terminology can use allowlist in their own uploader code. To make this change minimally intrusive as a start, the default whitelist methods now call the allowlist methods so either method can be overridden and it will work as expected while maintaining backwards compatibility. https://developers.google.com/style/word-list#blacklist rubocop/rubocop#6464
grantbdev
added a commit
to grantbdev/carrierwave
that referenced
this pull request
Dec 17, 2019
Add public interface alternative to blacklist so users who prefer not to use that terminology can use blocklist in their own uploader code. To make this change minimally intrusive as a start, the default blacklist methods now call the blocklist methods so either method can be overridden and it will work as expected while maintaining backwards compatibility. https://developers.google.com/style/word-list#blacklist rubocop/rubocop#6464
joemsak
pushed a commit
to Kadenze/carrierwave
that referenced
this pull request
Mar 27, 2021
Add public interface alternative to whitelist so users who prefer not to use that terminology can use allowlist in their own uploader code. To make this change minimally intrusive as a start, the default whitelist methods now call the allowlist methods so either method can be overridden and it will work as expected while maintaining backwards compatibility. https://developers.google.com/style/word-list#blacklist rubocop/rubocop#6464
joemsak
pushed a commit
to Kadenze/carrierwave
that referenced
this pull request
Mar 27, 2021
Add public interface alternative to blacklist so users who prefer not to use that terminology can use blocklist in their own uploader code. To make this change minimally intrusive as a start, the default blacklist methods now call the blocklist methods so either method can be overridden and it will work as expected while maintaining backwards compatibility. https://developers.google.com/style/word-list#blacklist rubocop/rubocop#6464
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request updates
cop/metrics/line_length.rb.Permitted is easier to understand and better terminology.
Original motivation, community efforts examples:
Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).and description in grammatically correct, complete sentences.
bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.