Fix false negative in Lint/Void with initialize and setter methods
#4457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbatsov
reviewed
Jun 3, 2017
spec/rubocop/cop/lint/void_spec.rb
Outdated
| end | ||
|
|
||
| it 'registers two offenses for void literals in an initialize method' do | ||
| expect_offense(<<-END.strip_indent) |
There was a problem hiding this comment.
Use RUBY everywhere consistently. We really need a cop to warn for usages of END.
bbatsov
reviewed
Jun 3, 2017
lib/rubocop/cop/lint/void.rb
Outdated
| @@ -102,6 +104,17 @@ def check_for_defined(node) | |||
|
|
|||
| add_offense(node, :expression, format(DEFINED_MSG, node.source)) | |||
| end | |||
|
|
|||
| # `initialize` and setter methods is not return value of last | |||
bbatsov
reviewed
Jun 3, 2017
| parent = node.parent | ||
| return false unless parent | ||
| method = parent.children.first | ||
| parent.def_type? && |
There was a problem hiding this comment.
@Drenmi I see a def node extension potential here. :-)
There was a problem hiding this comment.
Yes. Both def and defs have been on my list for some time. They're probably next. 🙂
In `initialize` and setter methods, returned value is ignored(See rubocop#4153). ```ruby def initialize 42 # This value is ignored. end ``` However, `Lint/Void` cop doesn't add an offense for the above code. This change makes to add an offense for the code.
That'd be best - he hasn't touched this in months and I have doubts he'll pick it up any time soon. |
3 tasks
5 tasks
This was referenced Nov 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
initializeand setter methods, returned value is ignored(See #4153).However,
Lint/Voidcop doesn't add an offense for the above code.This change makes to add an offense for the code.
Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).and description in grammatically correct, complete sentences.
rake generate_cops_documentation(required only when you've added a new cop or changed the configuration/documentation of an existing cop).