Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed new_cop.rake suggested path #4020

Merged
merged 1 commit into from
Feb 5, 2017
Merged

Conversation

dabroz
Copy link
Contributor

@dabroz dabroz commented Feb 5, 2017

rake new_cop[Style/Foobar] suggested to

- Add `require 'lib/rubocop/cop/style/foobar'` into lib/rubocop.rb

while actually paths in lib/rubocop.rb don't start with lib/. This fixes the issue and suggests a correct path instead.


Before submitting the PR make sure the following are checked:

  • Wrote good commit messages.
  • Used the same coding conventions as the rest of the project.
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
  • All tests are passing.
  • The new code doesn't generate RuboCop offenses.
  • The PR relates to only one subject with a clear title
    and description in grammatically correct, complete sentences.

@dabroz dabroz force-pushed the fix-new-cop branch 4 times, most recently from 623d939 to 745d92a Compare February 5, 2017 13:03
`rake new_cop[Style/Foobar]` suggested to

    - Add `require 'lib/rubocop/cop/style/foobar'` into lib/rubocop.rb

while actually paths in `lib/rubocop.rb` don't start with `lib/`. This fixes the issue and suggests a correct path instead.
@bbatsov bbatsov merged commit 713e6b9 into rubocop:master Feb 5, 2017
@bbatsov
Copy link
Collaborator

bbatsov commented Feb 5, 2017

👍

@dabroz dabroz deleted the fix-new-cop branch February 5, 2017 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants