[Fix #1935] Allow Symbol#to_proc blocks in Performance/Size #1936
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The heading of the commit message should start |
m1foley
changed the title
|
Oops, fixed the commit message. |
m1foley
force-pushed
the
size-sym-to-proc
branch
2 times, most recently
from
e5c608f
to
3bc06da
Compare
|
Added to CHANGELOG as well. |
|
The build is failing because of a couple of long lines. |
|
I've fixed the spec descriptions that were > 80 chars. I can't figure out why coveralls is failing though; the file I changed is still at 100% coverage. |
| it 'does not register an offense when calling count with a to_proc block' do | ||
| inspect_source(cop, '[1, 2, 3].count(&:nil?)') | ||
|
|
||
| expect(cop.messages).to be_empty |
There was a problem hiding this comment.
I'd suggest checking cop.offenses instead as it's more natural.
There was a problem hiding this comment.
Fixed. The rest of the spec still uses cop.messages though.
|
You can ignore this. Just address my tiny remark and rebase on top of the current |
This check should pass when passing a block to #count, but Symbol#to_proc blocks were not being allowed like they should.
|
Rebased on master. Should be good to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This check should pass when passing a block to
count, butSymbol#to_procblocks were not being allowed like they should.Fixes #1935