Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support unicode-display_width v3 #13481

Merged
merged 1 commit into from
Nov 21, 2024
Merged

Conversation

gemmaro
Copy link
Contributor

@gemmaro gemmaro commented Nov 20, 2024

This updates unicode-display_width gem's version limit to 3.0 to 4.0.

Reference: unicode-display_width change log at version 3.0.0


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

@gemmaro gemmaro marked this pull request as ready for review November 20, 2024 23:52
@gemmaro
Copy link
Contributor Author

gemmaro commented Nov 21, 2024

@koic Thank you for your review. Applied.

@koic koic merged commit e751b38 into rubocop:master Nov 21, 2024
19 checks passed
@koic
Copy link
Member

koic commented Nov 21, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants