Show Ruby version of the current dir for rubocop -V
#13347
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The rules are complex, even within the same project different ruby versions can be used for analysis. This makes
rubocop -V
output the ruby version of the current working directory.The first commit is a bit of cleanup. It was more difficult than necessary to understand where the
version
method is being used and how. Most callers simply wantRuboCop::Version::STRING
, i've updated these places. I wanted to just remove thedebug
option since it is marked private but standardrb uses it and other places useRuboCop::Version.version
as well anyways, regardless of intended visibility. Instead I've left a note, so that if it does get changed in the future, it can be more coordinated.Before submitting the PR make sure the following are checked:
[Fix #issue-number]
(if the related issue exists).master
(if not - rebase it).bundle exec rake default
. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.md
if the new code introduces user-observable changes. See changelog entry format for details.