We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
In #944 (comment), I mentioned that the SpaceBeforeFirstArg cop was generating a false positive offense for the following code:
SpaceBeforeFirstArg
ActionMailer::Base.smtp_settings = { address: 'smtp.sendgrid.net', port: '25', authentication: :plain, user_name: ENV['SENDGRID_USERNAME'], password: ENV['SENDGRID_PASSWORD'], domain: ENV['SENDGRID_DOMAIN'], }
I tried disabling that offense as follows:
ActionMailer::Base.smtp_settings = { # rubocop:disable SpaceBeforeFirstArg
This generated a new offense from the SpaceInsideHashLiteralBraces cop:
SpaceInsideHashLiteralBraces
C: Space inside { detected.
It seems to me that the SpaceInsideHashLiteralBraces cop should allow a comment (with a space before it) after opening brace.
The text was updated successfully, but these errors were encountered:
Same problem exists for array literals:
a = [ # comment 1, 2, 3 ]
Sorry, something went wrong.
924cfdd
Merge pull request #960 from jonas054/fix_957_space_inside
fe5784a
[Fix #957] Allow space + comment inside ( { and [
jonas054
No branches or pull requests
In #944 (comment), I mentioned that the
SpaceBeforeFirstArg
cop was generating a false positive offense for the following code:I tried disabling that offense as follows:
This generated a new offense from the
SpaceInsideHashLiteralBraces
cop:It seems to me that the
SpaceInsideHashLiteralBraces
cop should allow a comment (with a space before it) after opening brace.The text was updated successfully, but these errors were encountered: