Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MRI < 2.0 dependency problem on CI #3278

Closed
Drenmi opened this issue Jul 3, 2016 · 1 comment
Closed

MRI < 2.0 dependency problem on CI #3278

Drenmi opened this issue Jul 3, 2016 · 1 comment

Comments

@Drenmi
Copy link
Collaborator

Drenmi commented Jul 3, 2016 •
edited
Loading

I just created #3277, but Travis fails the Ruby 1.9 check because:

Gem::InstallError: json requires Ruby version ~> 2.0.

I assume this happens because parser tries to install json 2.0.1. From the json repo:

Drops support for old rubies whose life has ended, that is rubies < 2.0.

(This is a bit strange though, because parser's CI passes on all rubies.)
@Drenmi Drenmi changed the title MRI >2.0 dependency problem on CI MRI <2.0 dependency problem on CI Jul 3, 2016
@Drenmi Drenmi changed the title MRI <2.0 dependency problem on CI MRI < 2.0 dependency problem on CI Jul 3, 2016
@bbatsov
Copy link
Collaborator

bbatsov commented Jul 4, 2016

Yep, that's true. json 2.0 dropped support for Ruby 1.9, so I guess we'll have to drop support for 1.9 as well (or drop our json related features). parser itself supports even Ruby 1.8...

This was referenced Jul 5, 2016
Merged
Merged
Merged
Merged
Merged
@gerrywastaken gerrywastaken mentioned this issue Jul 6, 2016
Merged
10 tasks
gerrywastaken added a commit to gerrywastaken/rubocop that referenced this issue Jul 6, 2016
@gerrywastaken
[Fix rubocop#3278] Lock json version for 1.9.3 builds
4118877 
Recently the `json` gem was updated to require Ruby >= 2.0. This
causes our Ruby 1.9.3 build to fail. Here we lock the `json` gem
to the previously working version for 1.9 builds.
@bbatsov bbatsov closed this as completed in 49dd15a Jul 6, 2016
@gerrywastaken gerrywastaken mentioned this issue Jul 7, 2016
Merged
10 tasks
@Drenmi Drenmi mentioned this issue Jul 16, 2016
Closed
Neodelf pushed a commit to Neodelf/rubocop that referenced this issue Oct 15, 2016
@gerrywastaken @Neodelf
[Fix rubocop#3278] Lock json version for 1.9.3 builds (rubocop#3290)
a7e1b76 
Recently the `json` gem was updated to require Ruby >= 2.0. This
causes our Ruby 1.9.3 build to fail. Here we lock the `json` gem
to the previously working version for 1.9 builds.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bbatsov @Drenmi