-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unhandled Edge Case: Style/AccessModifierDeclarations #13213
Labels
Comments
koic
added a commit
to koic/rubocop
that referenced
this issue
Sep 9, 2024
…arations` Fixes rubocop#13213. This PR fixes false positives for `Style/AccessModifierDeclarations` when `AllowModifiersOnAttrs: true` and using splat with a percent array symbol literal, or with a constant.
8 tasks
koic
added a commit
to koic/rubocop
that referenced
this issue
Sep 9, 2024
…arations` Fixes rubocop#13213. This PR fixes false positives for `Style/AccessModifierDeclarations` when `AllowModifiersOnAttrs: true` and using splat with a percent symbol array, or with a constant.
@koic thank you for the quick response to this issue. For what it is worth, the PR looks good to me. |
bbatsov
pushed a commit
that referenced
this issue
Sep 24, 2024
Fixes #13213. This PR fixes false positives for `Style/AccessModifierDeclarations` when `AllowModifiersOnAttrs: true` and using splat with a percent symbol array, or with a constant.
koic
added a commit
to koic/rubocop
that referenced
this issue
Sep 27, 2024
…arations` Fixes rubocop#13213. This PR fixes false positives for `Style/AccessModifierDeclarations` when `AllowModifiersOnAttrs: true` and using splat with a percent symbol array, or with a constant.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
similar to #5953
Expected behavior
I expect symbol array literal notation to not be offensive to RuboCop
Actual behavior
Describe here what actually happened.
Offenses:
Steps to reproduce the problem
refactor a non-offensive use of AllowModifiersOnSymbols: true (default)
to use symbol array literal notation and re-run rubocop
Further down the rabbit hole
This is also throwing errors when the array of symbols is a variable or constant
When the array is not in array literal notation RuboCop suggests array literal notation, that is not being accepted by its sibling cop
RuboCop version
rubocop -v => 1.66.1
The text was updated successfully, but these errors were encountered: