Allow configuring enabled methods in . #593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bquorning
approved these changes
Apr 6, 2018
| # to make it obvious that the test uses capybara, while still disable | ||
| # the rest of the methods, like given (alias for let) or background | ||
| # (alias for before). You can configure which of the methods to be | ||
| # enabled by using the EnabledMethods configuration option. |
There was a problem hiding this comment.
I think capybara should be capitalised, i.e. Capybara.
Also shouldn’t the method names be wrapped in e.g. backticks?
Darhazer
force-pushed
the
allow-configuring-of-feature-methods
branch
from
fb4dd05 to
ab51707
Compare
bquorning
approved these changes
Apr 6, 2018
|
According to https://status.circleci.com/ Circle’s workflows aren’t working at the moment. Apparently there’s no such thing as the perfect CI. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some teams may prefer using some of the capybara methods (like
featureandscenario) while enforce usingbeforeandletfor the setup.This will also fix cases like #538 by allowing the usage of
feature.(We should also allow ignoring DescribeClass bases on the type meta-data)
cc: @rspeicher
Before submitting the PR make sure the following are checked:
master(if not - rebase it).bundle exec rake) is passing.If you have created a new cop:
config/default.yml.