Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix an edge offense for Style/SymbolProc #1881

Merged
merged 1 commit into from
May 19, 2024
Merged

Fix an edge offense for Style/SymbolProc #1881

merged 1 commit into from
May 19, 2024

Conversation

ydah
Copy link
Member

@ydah ydah commented May 19, 2024

see: https://github.com/rubocop/rubocop-rspec/actions/runs/9147530544/job/25149073488?pr=1876

Inspecting 272 files
.................................................................................C..............................................................................................................................................................................................

Offenses:

lib/rubocop/cop/rspec/multiple_expectations.rb:[7](https://github.com/rubocop/rubocop-rspec/actions/runs/9147530544/job/25149073488?pr=1876#step:5:8)5:25: C: [Correctable] Style/SymbolProc: Pass &:true_type? as an argument to lambda instead of a block.
        TRUE = ->(node) { node.true_type? }
                        ^^^^^^^^^^^^^^^^^^^

272 files inspected, 1 offense detected, 1 offense autocorrectable
Error: Process completed with exit code 1.

Before submitting the PR make sure the following are checked:

  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • [-] Added tests.
  • [-] Updated documentation.
  • [-] Added an entry to the CHANGELOG.md if the new code introduces user-observable changes.
  • The build (bundle exec rake) passes (be sure to run this locally, since it may produce updated documentation that you will need to commit).

@ydah ydah requested a review from a team as a code owner May 19, 2024 13:25
@bquorning bquorning merged commit 28bf477 into master May 19, 2024
24 checks passed
@bquorning bquorning deleted the fix-offense branch May 19, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants