Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support asserts with messages in Rspec/BeEmpty #1784

Merged
merged 1 commit into from
Jan 19, 2024

Conversation

G-Rath
Copy link
Contributor

@G-Rath G-Rath commented Jan 19, 2024

Adds support for when contain_exactly and `match_array are used with a message


Before submitting the PR make sure the following are checked:

  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Updated documentation.
  • Added an entry to the CHANGELOG.md if the new code introduces user-observable changes.
  • The build (bundle exec rake) passes (be sure to run this locally, since it may produce updated documentation that you will need to commit).

If you have created a new cop:

  • Added the new cop to config/default.yml.
  • The cop is configured as Enabled: pending in config/default.yml.
  • The cop is configured as Enabled: true in .rubocop.yml.
  • The cop documents examples of good and bad code.
  • The tests assert both that bad code is reported and that good code is not reported.
  • Set VersionAdded: "<<next>>" in default/config.yml.

If you have modified an existing cop's configuration options:

  • Set VersionChanged: "<<next>>" in config/default.yml.

@G-Rath G-Rath requested a review from a team as a code owner January 19, 2024 18:10
@G-Rath G-Rath force-pushed the support-be-empty-with-message branch from 5e054ad to 57f0bb1 Compare January 19, 2024 21:09
@G-Rath G-Rath force-pushed the support-be-empty-with-message branch from 57f0bb1 to 5187191 Compare January 19, 2024 21:15
@G-Rath G-Rath requested a review from pirj January 19, 2024 21:15
Copy link
Collaborator

@bquorning bquorning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what the failing CI check is about.

@G-Rath G-Rath force-pushed the support-be-empty-with-message branch from 5187191 to b0a257e Compare January 19, 2024 22:40
Copy link
Member

@ydah ydah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@ydah ydah merged commit 847fb7c into rubocop:master Jan 19, 2024
24 checks passed
@G-Rath G-Rath deleted the support-be-empty-with-message branch January 21, 2024 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants