Fix a false positive for RSpec/ExpectActual with rspec-rails #1764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
naveg
force-pushed
the
naveg/expect-actual-rails-routing
branch
2 times, most recently
from
01ac15d to
a2e2460
Compare
bquorning
reviewed
Jan 5, 2024
| @@ -50,6 +50,7 @@ class ExpectActual < Base | |||
| regexp | |||
| ].freeze | |||
|
|
|||
| SKIPPED_MATCHERS = %i[route_to be_routable].freeze | |||
There was a problem hiding this comment.
Since we are planning to extract the rspec-rails specific parts from rubocop-rspec, I don’t think we should hardcode these matchers names. Can we either have (the non-existing) rubocop-rspec-rails inject them, or maybe just add a SkippedMatchers to the configuration?
There was a problem hiding this comment.
Could we wait to see how the rails extraction takes shape before doing that? It's true that this is rails-specific, but it's also highly unlikely to matter, since we'd only miss adding offenses for non-rails matchers that happened to be named "route_to" or "be_routable".
naveg
force-pushed
the
naveg/expect-actual-rails-routing
branch
2 times, most recently
from
c53c48e to
eaf04e6
Compare
bquorning
approved these changes
Jan 9, 2024
bquorning
reviewed
Jan 9, 2024
naveg
force-pushed
the
naveg/expect-actual-rails-routing
branch
from
eaf04e6 to
d81260f
Compare
rspec-rails comes with routing matchers that use literals in the `expect()` Fixes rubocop#759
naveg
force-pushed
the
naveg/expect-actual-rails-routing
branch
from
d81260f to
30eef5c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rspec-rails comes with routing matchers that use literals in the
expect().Fixes #759
Before submitting the PR make sure the following are checked:
master(if not - rebase it).CHANGELOG.mdif the new code introduces user-observable changes.bundle exec rake) passes (be sure to run this locally, since it may produce updated documentation that you will need to commit).If you have created a new cop:
config/default.yml.Enabled: pendinginconfig/default.yml.Enabled: truein.rubocop.yml.VersionAdded: "<<next>>"indefault/config.yml.If you have modified an existing cop's configuration options:
VersionChanged: "<<next>>"inconfig/default.yml.