Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Ruby 3.3 to CI matrix #1758

Merged
merged 1 commit into from
Dec 30, 2023
Merged

Conversation

m-nakamura145
Copy link
Contributor

This PR adds Ruby 3.3 to CI matrix. It runs green on local.


Before submitting the PR make sure the following are checked:

  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Updated documentation.
  • Added an entry to the CHANGELOG.md if the new code introduces user-observable changes.
  • The build (bundle exec rake) passes (be sure to run this locally, since it may produce updated documentation that you will need to commit).

If you have created a new cop:

  • Added the new cop to config/default.yml.
  • The cop is configured as Enabled: pending in config/default.yml.
  • The cop is configured as Enabled: true in .rubocop.yml.
  • The cop documents examples of good and bad code.
  • The tests assert both that bad code is reported and that good code is not reported.
  • Set VersionAdded: "<<next>>" in default/config.yml.

If you have modified an existing cop's configuration options:

  • Set VersionChanged: "<<next>>" in config/default.yml.

Copy link
Member

@pirj pirj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@pirj pirj merged commit 25fda7b into rubocop:master Dec 30, 2023
24 checks passed
@pirj
Copy link
Member

pirj commented Dec 30, 2023

Wdyt of dropping 2.7 as it’s EOL, and also JRuby? @bquorning @Darhazer @ydah

@bquorning
Copy link
Collaborator

We usually only drop support for a Ruby version when RuboCop itself does, and I think we should continue doing it that way.

I’m fine with dropping the CI run for JRuby. I cannot remember one single time where specs failed for JRuby but passed for C Ruby. Of course we would keep supporting JRuby, but just treat problems via bug reports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants