Add NegatedMatcher configuration option to RSpec/ChangeByZero
#1349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pirj
approved these changes
Aug 3, 2022
ydah
force-pushed
the
add_option_for_change_by_zero
branch
4 times, most recently
from
118054e to
9a19cac
Compare
ydah
added a commit
to ydah/rubocop-rspec
that referenced
this pull request
Aug 4, 2022
4 tasks
pirj
force-pushed
the
add_option_for_change_by_zero
branch
from
9a19cac to
4e7abe7
Compare
|
Now passed the CI for default.yml . |
Darhazer
approved these changes
Aug 4, 2022
| compound expectations, but if you set the | ||
| negated matcher for `change`, e.g. `not_change` with | ||
| the `NegatedMatcher` option, the cop will perform the autocorrection. | ||
| `NegatedMatcher` option, will be autocorrect. |
There was a problem hiding this comment.
I was adding that I thought it might be confusing for cases that does not support autocorrected. I think a polite explanation would be about right. What do you think?
There was a problem hiding this comment.
I mean that the last sentence, ``NegatedMatcher option, will be autocorrect. is just repeating the previous one, and it's also incomplete anyway
There was a problem hiding this comment.
Ah! I was mistaken. Thank you very much. It is indeed so I have corrected it. How about it?
ydah
force-pushed
the
add_option_for_change_by_zero
branch
3 times, most recently
from
8bddf70 to
b01f898
Compare
4 tasks
This PR is add `NegatedMatcher` option to `RSpec/ChangeByZero`. In the case of composite expectations, cop suggest using the negation matchers of `RSpec::Matchers#change`. By default doe's not support autocorrect, but if you set the negation matcher of `RSpec::Matchers#change` defined in `NegatedMatcher` option, will be autocorrect.
ydah
force-pushed
the
add_option_for_change_by_zero
branch
from
b01f898 to
2d32d0d
Compare
Darhazer
approved these changes
Aug 9, 2022
pirj
pushed a commit
to rubocop/rubocop-capybara
that referenced
this pull request
Dec 29, 2022
ydah
added a commit
to rubocop/rubocop-factory_bot
that referenced
this pull request
Apr 13, 2023
ydah
added a commit
to rubocop/rubocop-rspec_rails
that referenced
this pull request
Mar 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is add
NegatedMatcheroption toRSpec/ChangeByZero.In the case of composite expectations, cop suggest using the negation matchers of
RSpec::Matchers#change.By default doe's not support autocorrect, but if you set the negation matcher of
RSpec::Matchers#changedefined inNegatedMatcheroption, will be autocorrect.Before submitting the PR make sure the following are checked:
master(if not - rebase it).CHANGELOG.mdif the new code introduces user-observable changes.bundle exec rake) passes (be sure to run this locally, since it may produce updated documentation that you will need to commit).If you have created a new cop:
config/default.yml.Enabled: pendinginconfig/default.yml.Enabled: truein.rubocop.yml.VersionAddedindefault/config.ymlto the next minor version.If you have modified an existing cop's configuration options:
VersionChangedinconfig/default.ymlto the next major version.