-
-
Notifications
You must be signed in to change notification settings - Fork 278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add docs on configuring RSpec aliases from gems #1097
Add docs on configuring RSpec aliases from gems #1097
Conversation
243ed13
to
f0f363d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you 🙇
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we pretty consistently use either lowercase rubocop-rspec
with a dash, or titlecase RuboCop RSpec
with a space.
docs/modules/ROOT/pages/third_party_rspec_syntax_extensions.adoc
Outdated
Show resolved
Hide resolved
docs/modules/ROOT/pages/third_party_rspec_syntax_extensions.adoc
Outdated
Show resolved
Hide resolved
docs/modules/ROOT/pages/third_party_rspec_syntax_extensions.adoc
Outdated
Show resolved
Hide resolved
docs/modules/ROOT/pages/third_party_rspec_syntax_extensions.adoc
Outdated
Show resolved
Hide resolved
docs/modules/ROOT/pages/third_party_rspec_syntax_extensions.adoc
Outdated
Show resolved
Hide resolved
5737495
to
22f8099
Compare
Indeed. |
Better viewed as https://github.com/rubocop-hq/rubocop-rspec/blob/add-doc-how-to-configure-rspec-aliases-in-third-party-gem/docs/modules/ROOT/pages/third_party_rspec_syntax_extensions.adoc
fixes #1077
Before submitting the PR make sure the following are checked:
master
(if not - rebase it).CHANGELOG.md
if the new code introduces user-observable changes.bundle exec rake
) passes (be sure to run this locally, since it may produce updated documentation that you will need to commit).