Merge pull request #2005 from rubocop/fix-empty-metadata-for-kwargs-s…

…plat Fix EmptyMetadata for splat kwargs
rubocop · Dec 11, 2024 · b8a0eb1 · b8a0eb1
2 parents 274c7d9 + 4832625
commit b8a0eb1
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 0 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -3,6 +3,7 @@
 ## Master (Unreleased)
 
 - Deprecate `top_level_group?` method from `TopLevelGroup` mixin as all of its callers were intentionally removed from `Rubocop/RSpec`. ([@corsonknowles])
+- Fix false positive for RSpec/EmptyMetadata for splat kwargs. ([@pirj])
 
 ## 3.2.0 (2024-10-26)
 

diff --git a/lib/rubocop/cop/rspec/empty_metadata.rb b/lib/rubocop/cop/rspec/empty_metadata.rb
@@ -21,6 +21,7 @@ class EmptyMetadata < Base
 
         def on_metadata(_symbols, hash)
           return unless hash&.pairs&.empty?
+          return if hash.children.any?(&:kwsplat_type?)
 
           add_offense(hash) do |corrector|
             remove_empty_metadata(corrector, hash)

diff --git a/spec/rubocop/cop/rspec/empty_metadata_spec.rb b/spec/rubocop/cop/rspec/empty_metadata_spec.rb
@@ -33,4 +33,11 @@
       RUBY
     end
   end
+
+  it 'registers no offense for splat kwargs metadata' do
+    expect_no_offenses(<<~RUBY)
+      describe 'Something', **{ a: b } do
+      end
+    RUBY
+  end
 end