Remove RSpec/Capybara/FeatureMethods

Fix: #1852

config/default.yml

@@ -298,8 +298,15 @@ RSpec/DescribedClassModuleWrapping:
 RSpec/Dialect:
   Description: Enforces custom RSpec dialects.
   Enabled: false
-  PreferredMethods: {}
+  PreferredMethods:
+    background: before
+    scenario: it
+    xscenario: xit
+    given: let
+    given!: let!
+    feature: describe
   VersionAdded: '1.33'
+  VersionChanged: "<<next>>"
   Reference: https://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/Dialect
 
 RSpec/DuplicatedMetadata:
@@ -1018,14 +1025,6 @@ RSpec/Capybara/CurrentPathExpectation:
   VersionChanged: '2.0'
   Reference: https://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/Capybara/CurrentPathExpectation
 
-RSpec/Capybara/FeatureMethods:
-  Description: Checks for consistent method usage in feature specs.
-  Enabled: true
-  EnabledMethods: []
-  VersionAdded: '1.17'
-  VersionChanged: '2.0'
-  Reference: https://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/Capybara/FeatureMethods
-
 RSpec/Capybara/MatchStyle:
   Description: Checks for usage of deprecated style methods.
   Enabled: pending

config/obsoletion.yml

@@ -34,3 +34,9 @@ renamed:
   RSpec/Rails/MinitestAssertions: RSpecRails/MinitestAssertions
   RSpec/Rails/NegationBeValid: RSpecRails/NegationBeValid
   RSpec/Rails/TravelAround: RSpecRails/TravelAround
+
+removed:
+  RSpec/Capybara/FeatureMethods:
+    reason: >
+      this cop has migrated to `RSpec/Dialect`. Please use `RSpec/Dialect` instead.
+      in .rubocop.yml file, enable `RSpec/Dialect`.

docs/modules/ROOT/pages/cops.adoc

@@ -115,7 +115,6 @@
 === Department xref:cops_rspec_capybara.adoc[RSpec/Capybara]
 
 * xref:cops_rspec_capybara.adoc#rspeccapybara/currentpathexpectation[RSpec/Capybara/CurrentPathExpectation]
-* xref:cops_rspec_capybara.adoc#rspeccapybara/featuremethods[RSpec/Capybara/FeatureMethods]
 * xref:cops_rspec_capybara.adoc#rspeccapybara/matchstyle[RSpec/Capybara/MatchStyle]
 * xref:cops_rspec_capybara.adoc#rspeccapybara/negationmatcher[RSpec/Capybara/NegationMatcher]
 * xref:cops_rspec_capybara.adoc#rspeccapybara/specificactions[RSpec/Capybara/SpecificActions]

docs/modules/ROOT/pages/cops_rspec.adoc

@@ -1044,7 +1044,7 @@ end
 | Yes
 | Always
 | 1.33
-| -
+| <<next>>
 |===
 
 Enforces custom RSpec dialects.
@@ -1096,7 +1096,7 @@ end
 | Name | Default value | Configurable values
 
 | PreferredMethods
-| `{}`
+| `{"background"=>"before", "scenario"=>"it", "xscenario"=>"xit", "given"=>"let", "given!"=>"let!", "feature"=>"describe"}`
 | 
 |===
 

docs/modules/ROOT/pages/cops_rspec_capybara.adoc

@@ -51,73 +51,6 @@ expect(page).to have_current_path('/callback')
 
 * https://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/Capybara/CurrentPathExpectation
 
-== RSpec/Capybara/FeatureMethods
-
-|===
-| Enabled by default | Safe | Supports autocorrection | Version Added | Version Changed
-
-| Enabled
-| Yes
-| Always
-| 1.17
-| 2.0
-|===
-
-Checks for consistent method usage in feature specs.
-
-By default, the cop disables all Capybara-specific methods that have
-the same native RSpec method (e.g. are just aliases). Some teams
-however may prefer using some of the Capybara methods (like `feature`)
-to make it obvious that the test uses Capybara, while still disable
-the rest of the methods, like `given` (alias for `let`), `background`
-(alias for `before`), etc. You can configure which of the methods to
-be enabled by using the EnabledMethods configuration option.
-
-=== Examples
-
-[source,ruby]
-----
-# bad
-feature 'User logs in' do
-  given(:user) { User.new }
-
-  background do
-    visit new_session_path
-  end
-
-  scenario 'with OAuth' do
-    # ...
-  end
-end
-
-# good
-describe 'User logs in' do
-  let(:user) { User.new }
-
-  before do
-    visit new_session_path
-  end
-
-  it 'with OAuth' do
-    # ...
-  end
-end
-----
-
-=== Configurable attributes
-
-|===
-| Name | Default value | Configurable values
-
-| EnabledMethods
-| `[]`
-| Array
-|===
-
-=== References
-
-* https://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/Capybara/FeatureMethods
-
 == RSpec/Capybara/MatchStyle
 
 |===

lib/rubocop/cop/rspec_cops.rb

@@ -1,7 +1,6 @@
 # frozen_string_literal: true
 
 require_relative 'rspec/capybara/current_path_expectation'
-require_relative 'rspec/capybara/feature_methods'
 require_relative 'rspec/capybara/match_style'
 require_relative 'rspec/capybara/negation_matcher'
 require_relative 'rspec/capybara/specific_actions'