Fix Rails/TimeZone should not report offense on String#to_time with timezone specifier
#1367
Conversation
| @@ -27,7 +27,8 @@ module Rails | |||
| # Time.current | |||
| # Time.zone.now | |||
| # Time.zone.parse('2015-03-02T19:05:37') | |||
| # Time.zone.parse('2015-03-02T19:05:37Z') # Respect ISO 8601 format with timezone specifier. | |||
There was a problem hiding this comment.
Was this an intentional removal? If so, what was the intention behind it?
There was a problem hiding this comment.
Sorry I wanted to explain the change in the PR body and forgot to do it
This example was added in PR #441 which specifically allows Time.parse when a timezone specifier is present so Time.parse(...) seems like the good syntax in that case
There was a problem hiding this comment.
Hm, this deleted example (Time.zone.parse('2015-03-02T19:05:37Z')) still seems like a good use case. Can you restore it instead of removing it?
There was a problem hiding this comment.
Good point 👍 Done in 737721c
|
Looks good to me. Can you squash your commits into one? |
…th timezone specifier
As `Time.parse("2012-03-02T16:05:37Z")` is allowed, `"2012-03-02T16:05:37Z".to_time` should also be allowed.
armandmgt
force-pushed
the
feature/allow-to_time-with-specifier
branch
from
737721c
to
5bc926f
Compare
|
I'm going to merge this PR because the CI failure has been fixed in the master branch. Thank you! |
As
Time.parse("2012-03-02T16:05:37Z")is allowed,"2012-03-02T16:05:37Z".to_timeshould also be allowed.Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.