Merge pull request #203 from koic/support_it_block

[Fix #200] Support `it` testing block for minitest/spec

changelog/new_support_it_block.md

@@ -0,0 +1 @@
+* [#200](https://github.com/rubocop/rubocop-minitest/issues/200): Support `it` testing block for minitest/spec. ([@koic][])

lib/rubocop/cop/mixin/minitest_exploration_helpers.rb

@@ -38,7 +38,7 @@ def test_cases(class_node)
 
         # Support Active Support's `test 'example' { ... }` method.
         # https://api.rubyonrails.org/classes/ActiveSupport/Testing/Declarative.html
-        test_blocks = class_node.each_descendant(:block).select { |block_node| block_node.method?(:test) }
+        test_blocks = class_node.each_descendant(:block).select { |block| block.method?(:test) || block.method?(:it) }
 
         test_cases + test_blocks
       end

test/rubocop/cop/minitest/no_assertions_test.rb

@@ -26,7 +26,7 @@ def test_another_valid_test
     RUBY
   end
 
-  def test_registers_offense_when_no_assertions_in_block_form
+  def test_registers_offense_when_no_assertions_in_test_block_form
     assert_offense(<<~RUBY)
       class FooTest < Minitest::Test
         include Foo
@@ -49,6 +49,25 @@ class FooTest < Minitest::Test
     RUBY
   end
 
+  def test_registers_offense_when_no_assertions_in_it_block_form
+    assert_offense(<<~RUBY)
+      class FooTest < Minitest::Test
+        describe Foo do
+          setup { }
+          teardown { }
+
+          it "asserts the truth" do
+            assert true
+          end
+
+          it "does nothing" do
+          ^^^^^^^^^^^^^^^^^^^^ Test case has no assertions.
+          end
+        end
+      end
+    RUBY
+  end
+
   def test_register_no_offense_if_test_has_assertion
     assert_no_offenses(<<~RUBY)
       class FooTest < Minitest::Test