Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use spec.add_runtime_dependency 'rubocop', '~> 1.41' #96

Merged
merged 1 commit into from
Jan 4, 2024

Conversation

ydah
Copy link
Member

@ydah ydah commented Jan 4, 2024

Fix: #89


Before submitting the PR make sure the following are checked:

  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • [-] Added tests.
  • [-] Updated documentation.
  • [-] Added an entry to the CHANGELOG.md if the new code introduces user-observable changes.
  • The build (bundle exec rake) passes (be sure to run this locally, since it may produce updated documentation that you will need to commit).

Copy link
Member

@pirj pirj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the quick fix

@pirj pirj merged commit e0c0e5d into master Jan 4, 2024
24 checks passed
@pirj pirj deleted the bump-rubocop-version branch January 4, 2024 18:54
@pirj
Copy link
Member

pirj commented Jan 4, 2024

Quickmerging as we have the same in rubocop-capybara.

@pirj
Copy link
Member

pirj commented Jan 4, 2024

In the hindsight, we need a changelog entry to highlight this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

undefined method `inject_defaults!' for RuboCop::ConfigLoader:Class with rubocop < 1.50
2 participants