-
-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a new Capybara/NegationMatcherAfterVisit
cop
#36
Conversation
I recently diagnosed and then fixed code in my project that would have benefited from this cop. Any thing I can do to help move it along? |
In case it helps, I rebased your work to resolve the merge conflicts: #140 But if this PR resumes, I'm happy to close it in favor of this one. |
@boris-petrov does this look right to you? @ydah can you please rebase? |
Rebased this PR |
Resolve: #7 This PR adds a new `Capybara/NegationMatcherAfterVisit` cop.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! 🙌
I will wait for @jdufresne response this question before merging. |
What question exactly? I can’t find anything blocking. What am I missing? |
The linked comment does not address me directly but it does address two others. What question would like me to answer? |
@jdufresne Ah! Sorry. I misunderstood the mentions destination. |
Resolve: #7
This PR adds a new
Capybara/NegationMatcherAfterVisit
cop.Before submitting the PR make sure the following are checked:
main
(if not - rebase it).CHANGELOG.md
if the new code introduces user-observable changes.bundle exec rake
) passes (be sure to run this locally, since it may produce updated documentation that you will need to commit).If you have created a new cop:
config/default.yml
.Enabled: pending
inconfig/default.yml
.VersionAdded: "<<next>>"
indefault/config.yml
.