Fix example code in the SpecificMatcher cop
#120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ydah
reviewed
May 24, 2024
| @@ -23,7 +23,7 @@ module Capybara | |||
| # expect(page).to have_no_link('foo', class: 'cls', href: 'http://example.com') | |||
| # expect(page).to have_table(class: 'cls') | |||
| # expect(page).to have_select | |||
| # expect(page).to have_field('foo') | |||
| # expect(page).to have_field(with: 'foo') | |||
There was a problem hiding this comment.
question) Example to verify that the name attribute has an input field of 'foo', is there a problem with the code in the original example?
There was a problem hiding this comment.
It's not exactly a problem per se, it's just that all the rest of the example correspond to a line in the bad part. Only the last one is different - and I think the intention was for it also to be the same - just the correct way to write it. Adding the with: does that - makes it with the same meaning as the "bad" example.
|
Could you check failed CI? |
|
Sorry about that. I think I fixed it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The title says it all.
Before submitting the PR make sure the following are checked:
main(if not - rebase it).CHANGELOG.mdif the new code introduces user-observable changes.bundle exec rake) passes (be sure to run this locally, since it may produce updated documentation that you will need to commit).