Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move the department associated with Capybara::RSpecMatchers to Capybara/RSpec/* #113

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ydah
Copy link
Member

@ydah ydah commented Mar 22, 2024

This PR move the department associated with Capybara::RSpecMatchers to Capybara/RSpec/*.

Capybara/CurrentPathExpectation, Capybara/SpecificMatcher, Capybara/NegationMatcher, and Capybara/VisibilityMatcher cops depend on methods from the Capybara::RSpecMatchers class.

https://www.rubydoc.info/gems/capybara/Capybara/RSpecMatchers

This is breaking changes and will be planned during the major upgrade to RuboCop Capybara3.0.


Before submitting the PR make sure the following are checked:

  • Feature branch is up-to-date with main (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Updated documentation.
  • Added an entry to the CHANGELOG.md if the new code introduces user-observable changes.
  • The build (bundle exec rake) passes (be sure to run this locally, since it may produce updated documentation that you will need to commit).

If you have created a new cop:

  • Added the new cop to config/default.yml.
  • The cop is configured as Enabled: pending in config/default.yml.
  • The cop documents examples of good and bad code.
  • The tests assert both that bad code is reported and that good code is not reported.
  • Set VersionAdded: "<<next>>" in default/config.yml.

If you have modified an existing cop's configuration options:

  • Set VersionChanged: "<<next>>" in config/default.yml.

Copy link

1 Warning
⚠️ There is a cop that became Enabled: true due to this pull request.
Please review the diff and make sure there are no issues.

Generated by 🚫 Danger

@ydah ydah self-assigned this Mar 22, 2024
@ydah ydah added this to the 3.0 milestone Mar 22, 2024
@ydah ydah force-pushed the move-to-rspec-dept branch 2 times, most recently from 356f861 to ad47865 Compare June 11, 2024 16:36
@ydah ydah marked this pull request as ready for review June 11, 2024 16:38
@ydah ydah requested a review from a team as a code owner June 11, 2024 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant