Refactor TOC HTML/CSS #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes rubenpieters#2 This commit introduces a new data attribute added to a top level html node. This attribute is a flag which determines the open/close state of the TOC. CSS rules are rewritten to refrence this. A CSS variable is introduced for controlling TOC width. The top level container is no longer a grid. The TOC is rendered offscreen. When it is toggled to display, all of the page content is moved using transforms sideways, revealing the TOC. Because no page elements change size, no reflow occurs, solving the problem in rubenpieters#2. The close button on the TOC could often scroll out of view. To fix this, the TOC HTML has been tweaked so that a header with the title and close button stays fixed, and only the TOC UL scrolls.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2
This commit introduces a new data attribute added to a top level html node. This attribute is a flag which determines the open/close state of the TOC. CSS rules are rewritten to refrence this. A CSS variable is introduced for controlling TOC width.
The top level container is no longer a grid.
The TOC is rendered offscreen. When it is toggled to display, all of the page content is moved using transforms sideways, revealing the TOC. Because no page elements change size, no reflow occurs, solving the problem in #2.
The close button on the TOC could often scroll out of view. To fix this, the TOC HTML has been tweaked so that a header with the title and close button stays fixed, and only the TOC UL scrolls.