-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add enabledOperators parameter for workspace name unique check #306
Add enabledOperators parameter for workspace name unique check #306
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## workspace-pr-integr #306 +/- ##
========================================================
+ Coverage 35.17% 53.55% +18.37%
========================================================
Files 1885 2236 +351
Lines 36421 43517 +7096
Branches 6672 8091 +1419
========================================================
+ Hits 12810 23304 +10494
+ Misses 22761 18566 -4195
- Partials 850 1647 +797
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
de39f84
to
67b6a1d
Compare
67b6a1d
to
bb9076a
Compare
Overall looks good to me. But can we add a integration_test for this case? You can leverage the workspace CRUD integration test file to add the enabledOperators related test cases. |
sure, will add a test for it |
Signed-off-by: Hailong Cui <[email protected]>
Signed-off-by: Hailong Cui <[email protected]>
Signed-off-by: Hailong Cui <[email protected]>
bb9076a
to
377286d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Description
Add enabledOperators parameter for workspace name unique check. The default value for this flag is
ALL
means all operators are supported.For example we have workspace named
test-workspace
and now we create a new workspace namedtest test-workspace
that will match existingtest-workspace
by using simple query string and leads name unique check failed.Issues Resolved
Screenshot
Testing the changes
Check List
yarn test:jest
yarn test:jest_integration