[Vis Augmenter] Fix stats API visualization ID bug (opensearch-projec…

…t#4565) (opensearch-project#4567) * Fix vis augmenter stats api vis ID map * Update changelog * Update tests * Remove changelog entry --------- (cherry picked from commit 72e7068) Signed-off-by: Tyler Ohlsen <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ruanyl · Jul 13, 2023 · 23d6f18 · 23d6f18
1 parent ab5017a
commit 23d6f18
Show file tree

Hide file tree

Showing 2 changed files with 37 additions and 6 deletions.
diff --git a/src/plugins/vis_augmenter/server/routes/stats_helpers.test.ts b/src/plugins/vis_augmenter/server/routes/stats_helpers.test.ts
@@ -14,6 +14,7 @@ const PLUGIN_RESOURCE_TYPE_2 = 'plugin-resource-type-2';
 const PLUGIN_RESOURCE_ID_1 = 'plugin-resource-id-1';
 const PLUGIN_RESOURCE_ID_2 = 'plugin-resource-id-2';
 const PLUGIN_RESOURCE_ID_3 = 'plugin-resource-id-3';
+const VIS_REF_NAME = 'visualization_0';
 const VIS_ID_1 = 'vis-id-1';
 const VIS_ID_2 = 'vis-id-2';
 const PER_PAGE = 4;
@@ -26,8 +27,14 @@ const SINGLE_SAVED_OBJ = [
         type: PLUGIN_RESOURCE_TYPE_1,
         id: PLUGIN_RESOURCE_ID_1,
       },
-      visId: VIS_ID_1,
+      visName: VIS_REF_NAME,
     },
+    references: [
+      {
+        name: VIS_REF_NAME,
+        id: VIS_ID_1,
+      },
+    ],
   },
 ] as Array<SavedObjectsFindResult<AugmentVisSavedObjectAttributes>>;
 
@@ -39,8 +46,14 @@ const MULTIPLE_SAVED_OBJS = [
         type: PLUGIN_RESOURCE_TYPE_1,
         id: PLUGIN_RESOURCE_ID_1,
       },
-      visId: VIS_ID_1,
+      visName: VIS_REF_NAME,
     },
+    references: [
+      {
+        name: VIS_REF_NAME,
+        id: VIS_ID_1,
+      },
+    ],
   },
   {
     attributes: {
@@ -49,8 +62,14 @@ const MULTIPLE_SAVED_OBJS = [
         type: PLUGIN_RESOURCE_TYPE_2,
         id: PLUGIN_RESOURCE_ID_2,
       },
-      visId: VIS_ID_1,
+      visName: VIS_REF_NAME,
     },
+    references: [
+      {
+        name: VIS_REF_NAME,
+        id: VIS_ID_1,
+      },
+    ],
   },
   {
     attributes: {
@@ -59,8 +78,14 @@ const MULTIPLE_SAVED_OBJS = [
         type: PLUGIN_RESOURCE_TYPE_2,
         id: PLUGIN_RESOURCE_ID_2,
       },
-      visId: VIS_ID_2,
+      visName: VIS_REF_NAME,
     },
+    references: [
+      {
+        name: VIS_REF_NAME,
+        id: VIS_ID_2,
+      },
+    ],
   },
   {
     attributes: {
@@ -69,8 +94,14 @@ const MULTIPLE_SAVED_OBJS = [
         type: PLUGIN_RESOURCE_TYPE_2,
         id: PLUGIN_RESOURCE_ID_3,
       },
-      visId: VIS_ID_1,
+      visName: VIS_REF_NAME,
     },
+    references: [
+      {
+        name: VIS_REF_NAME,
+        id: VIS_ID_1,
+      },
+    ],
   },
 ] as Array<SavedObjectsFindResult<AugmentVisSavedObjectAttributes>>;
 

diff --git a/src/plugins/vis_augmenter/server/routes/stats_helpers.ts b/src/plugins/vis_augmenter/server/routes/stats_helpers.ts
@@ -68,7 +68,7 @@ export const getStats = (
     const originPlugin = augmentVisObj.attributes.originPlugin;
     const pluginResourceType = augmentVisObj.attributes.pluginResource.type;
     const pluginResourceId = augmentVisObj.attributes.pluginResource.id;
-    const visualizationId = augmentVisObj.attributes.visId as string;
+    const visualizationId = augmentVisObj.references[0].id as string;
 
     originPluginMap[originPlugin] = (get(originPluginMap, originPlugin, 0) as number) + 1;
     pluginResourceTypeMap[pluginResourceType] =