move all management of jobs executions to ScheduledJobManager #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KazankovMarch
force-pushed
the
move_jobs_execuitons_management_to_separate_class
branch
from
4806970
to
c201bf2
Compare
swarmshine
requested changes
Dec 25, 2020
distributed-job-manager/src/main/java/ru/fix/distributed/job/manager/ScheduledJobManager.java
Show resolved
Hide resolved
| Profiler profiler, | ||
| String workerId, | ||
| DynamicProperty<DistributedJobManagerSettings> settings, | ||
| AtomicBoolean isWorkerShutdown |
There was a problem hiding this comment.
isWorkerShutdown breaked borders and leaked into ScheduledJobManager. Maybe isWorkerShutdown should stay in worker class, and worker should use and decide whether to call restartJobsAccordingToNewAssignments or not depending on Worker state?
There was a problem hiding this comment.
I agree. I have a suggestion for ReschedulableScheduler API: ru-fix/jfix-stdlib#73
phoenigm
approved these changes
Mar 23, 2021
swarmshine
requested changes
Apr 7, 2021
| profiler | ||
| ); | ||
| } | ||
|
|
||
| synchronized List<ScheduledJobExecution> getScheduledJobExecutions(JobDescriptor distributedJob) { |
…s_management_to_separate_class # Conflicts: # distributed-job-manager/src/main/java/ru/fix/distributed/job/manager/Worker.java
swarmshine
requested changes
Oct 13, 2021
| return scheduledJobs.get(distributedJob); | ||
| } | ||
|
|
||
| synchronized void removeIf(Predicate<Map.Entry<JobDescriptor, List<ScheduledJobExecution>>> predicate) { | ||
| private synchronized void removeIf(Predicate<Map.Entry<JobDescriptor, List<ScheduledJobExecution>>> predicate) { |
There was a problem hiding this comment.
Seems like there is no need for synchronized for this private methods
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to resolve issue #71, but management of jobs executions is separated between Worker and ScheduledJobManager
Worker is too complex class, so let's make that only ScheduledJobManager now responsible for management of jobs executions. Such a first step for refactoring Worker class
Note: I didn't change any DJM logic in this PR, I only moved some blocks of code from Worker to ScheduledJobManager; I suggest refactor ScheduledJobManager in next PR