Minor doc/rename changes #2
Conversation
|
Thanks for opening a pull request! If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project. Then could you also rename the pull request title in the following format? or In the case of PARQUET issues on JIRA the title also supports: See also: |
| // This is not zero copy - we should refactor the code to pass | ||
| // offset and length to Consume to avoid copying here | ||
| auto exec_batch = full_batch.Slice(segment.offset, segment.length); | ||
| auto batch = ExecSpan(exec_batch); |
There was a problem hiding this comment.
You're right this is not zero-copy, but I believe this can be fixed within this block of code. Let's write something like "TODO: fix this to be zero-copy".
There was a problem hiding this comment.
I changed my post above because the fix I have in mind involves adding ExecSpan::Slice, which would require a bit of testing that I'd prefer to defer on.
| /// @param[out] values_ptr Vector to store the extracted segment key values | ||
| /// @param[in] input_batch Segment batch. Must have the a constant value for segment key | ||
| /// @param[in] field_ids Segment key field ids | ||
| /// @return |
There was a problem hiding this comment.
The empty @return is causing CI failures like this one. Either remove or complete.
@rtpsw minor changes