Skip to content

Commit

Permalink
apacheGH-35118: [Format][FlightSQL] More use int32 to refer to 32-b…
Browse files Browse the repository at this point in the history 
…it integers rather than `int` (apache#35213)

### Rationale for this change

There are more inconsistency of the spec format found  -- see details on the original issue apache#35118. apache#35120 is the first PR with the same fix.

### What changes are included in this PR?

Use `int32` to refer to 32-bit integers rather than `int`

### Are these changes tested?

No, only comments are changed

### Are there any user-facing changes?

This clarifies a small corner case in the document

* Closes: apache#35118

Authored-by: Chunchun <[email protected]>
Signed-off-by: Sutou Kouhei <[email protected]>
  • Loading branch information
@appletreeisyellow @rtpsw
appletreeisyellow authored and rtpsw committed May 16, 2023
1 parent d215be6 commit de25e2a
Showing 1 changed file with 30 additions and 30 deletions.
60 changes: 30 additions & 30 deletions format/FlightSql.proto
View file
Original file line number Diff line number Diff line change
Expand Up @@ -1064,12 +1064,12 @@ enum Searchable {
* The returned schema will be:
* <
* type_name: utf8 not null (The name of the data type, for example: VARCHAR, INTEGER, etc),
* data_type: int not null (The SQL data type),
* column_size: int (The maximum size supported by that column.
* In case of exact numeric types, this represents the maximum precision.
* In case of string types, this represents the character length.
* In case of datetime data types, this represents the length in characters of the string representation.
* NULL is returned for data types where column size is not applicable.),
* data_type: int32 not null (The SQL data type),
* column_size: int32 (The maximum size supported by that column.
* In case of exact numeric types, this represents the maximum precision.
* In case of string types, this represents the character length.
* In case of datetime data types, this represents the length in characters of the string representation.
* NULL is returned for data types where column size is not applicable.),
* literal_prefix: utf8 (Character or characters used to prefix a literal, NULL is returned for
* data types where a literal prefix is not applicable.),
* literal_suffix: utf8 (Character or characters used to terminate a literal,
Expand All @@ -1078,38 +1078,38 @@ enum Searchable {
* (A list of keywords corresponding to which parameters can be used when creating
* a column for that specific type.
* NULL is returned if there are no parameters for the data type definition.),
* nullable: int not null (Shows if the data type accepts a NULL value. The possible values can be seen in the
* Nullable enum.),
* nullable: int32 not null (Shows if the data type accepts a NULL value. The possible values can be seen in the
* Nullable enum.),
* case_sensitive: bool not null (Shows if a character data type is case-sensitive in collations and comparisons),
* searchable: int not null (Shows how the data type is used in a WHERE clause. The possible values can be seen in the
* Searchable enum.),
* searchable: int32 not null (Shows how the data type is used in a WHERE clause. The possible values can be seen in the
* Searchable enum.),
* unsigned_attribute: bool (Shows if the data type is unsigned. NULL is returned if the attribute is
* not applicable to the data type or the data type is not numeric.),
* fixed_prec_scale: bool not null (Shows if the data type has predefined fixed precision and scale.),
* auto_increment: bool (Shows if the data type is auto incremental. NULL is returned if the attribute
* is not applicable to the data type or the data type is not numeric.),
* local_type_name: utf8 (Localized version of the data source-dependent name of the data type. NULL
* is returned if a localized name is not supported by the data source),
* minimum_scale: int (The minimum scale of the data type on the data source.
* If a data type has a fixed scale, the MINIMUM_SCALE and MAXIMUM_SCALE
* columns both contain this value. NULL is returned if scale is not applicable.),
* maximum_scale: int (The maximum scale of the data type on the data source.
* NULL is returned if scale is not applicable.),
* sql_data_type: int not null (The value of the SQL DATA TYPE which has the same values
* as data_type value. Except for interval and datetime, which
* uses generic values. More info about those types can be
* obtained through datetime_subcode. The possible values can be seen
* in the XdbcDataType enum.),
* datetime_subcode: int (Only used when the SQL DATA TYPE is interval or datetime. It contains
* its sub types. For type different from interval and datetime, this value
* is NULL. The possible values can be seen in the XdbcDatetimeSubcode enum.),
* num_prec_radix: int (If the data type is an approximate numeric type, this column contains
* the value 2 to indicate that COLUMN_SIZE specifies a number of bits. For
* exact numeric types, this column contains the value 10 to indicate that
* column size specifies a number of decimal digits. Otherwise, this column is NULL.),
* interval_precision: int (If the data type is an interval data type, then this column contains the value
* of the interval leading precision. Otherwise, this column is NULL. This fields
* is only relevant to be used by ODBC).
* minimum_scale: int32 (The minimum scale of the data type on the data source.
* If a data type has a fixed scale, the MINIMUM_SCALE and MAXIMUM_SCALE
* columns both contain this value. NULL is returned if scale is not applicable.),
* maximum_scale: int32 (The maximum scale of the data type on the data source.
* NULL is returned if scale is not applicable.),
* sql_data_type: int32 not null (The value of the SQL DATA TYPE which has the same values
* as data_type value. Except for interval and datetime, which
* uses generic values. More info about those types can be
* obtained through datetime_subcode. The possible values can be seen
* in the XdbcDataType enum.),
* datetime_subcode: int32 (Only used when the SQL DATA TYPE is interval or datetime. It contains
* its sub types. For type different from interval and datetime, this value
* is NULL. The possible values can be seen in the XdbcDatetimeSubcode enum.),
* num_prec_radix: int32 (If the data type is an approximate numeric type, this column contains
* the value 2 to indicate that COLUMN_SIZE specifies a number of bits. For
* exact numeric types, this column contains the value 10 to indicate that
* column size specifies a number of decimal digits. Otherwise, this column is NULL.),
* interval_precision: int32 (If the data type is an interval data type, then this column contains the value
* of the interval leading precision. Otherwise, this column is NULL. This fields
* is only relevant to be used by ODBC).
* >
* The returned data should be ordered by data_type and then by type_name.
*/
Expand Down

0 comments on commit de25e2a

Please sign in to comment.