Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove test files from bundled gem #339

Merged
merged 1 commit into from
Dec 7, 2018
Merged

Remove test files from bundled gem #339

merged 1 commit into from
Dec 7, 2018

Conversation

greysteil
Copy link
Contributor

@greysteil greysteil commented Dec 1, 2018

First of all, thanks for Tilt!

This PR slims down the bundled gem by ~60% by:

  • removing the test_files declaration (which is deprecated)
  • removing all files which aren't required to build the gem from the files declaration. This is pretty standard practice

The same saving is a big percentage but small in absolute terms (30KB different in the .gem). Hopefully that's still worth having since this gem is downloaded millions of times.

@judofyr
Copy link
Collaborator

judofyr commented Dec 4, 2018

Looks good to me!

@judofyr
Copy link
Collaborator

judofyr commented Dec 4, 2018

Actually. That gemspec is generated in the Rakefile:

tilt/Rakefile

Line 88 in 24aff97

file 'tilt.gemspec' => FileList['{lib,test}/**','Rakefile'] do |f|
. We'd have to change that code in order for the gemspec to be respected.

@greysteil
Copy link
Contributor Author

Updated the rakefile - generates a gemspec without tests now.

@judofyr
Copy link
Collaborator

judofyr commented Dec 7, 2018

Now it looks good!

@judofyr judofyr merged commit 857deb0 into rtomayko:master Dec 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants