Implement support for SVCB and HTTPS records #452
Conversation
|
Thanks for submitting! I will leave this PR open so other early adopters can find it. Once it has an RFC and official code points, we can merge it. |
dns/rdtypes/svcbbase.py
Outdated
|
|
||
| return addrs | ||
|
|
||
| if key == "esniconfig": |
There was a problem hiding this comment.
Needs update to latest draft version, the name has changed.
Codecov Report
@@ Coverage Diff @@
## master #452 +/- ##
==========================================
+ Coverage 95.35% 95.41% +0.06%
==========================================
Files 102 105 +3
Lines 7427 7683 +256
==========================================
+ Hits 7082 7331 +249
- Misses 345 352 +7
Continue to review full report at Codecov.
|
ghedo
changed the title
|
Update with new names (HTTPSSVC -> HTTPS, esniconfig -> echconfig). |
This implements the SVBC and HTTPS records as described in https://tools.ietf.org/html/draft-ietf-dnsop-svcb-https-00 Given that the dnspython library is often used to test other implementations, it is useful for it to implement this draft, even though it's not finalized yet, to help with interop testing. The wire and presentation formats for SVCB and HTTPS are identical, so the base RD implementation is split into its own class, so that it can be reused for all records that have the same format.
|
FTR, SVCB and HTTPS now have official code-points: so I updated the PR to use those instead of the private-use ones. |
|
We did a massive overhaul of rdata wire processing today, making things much nicer. If you're ok with overhauling this PR to support the new scheme (look at from_wire_parser() in any rdata type), that's cool. If that's too much work, then I will update your patch once there is an RFC and then merge it. |
|
The wire format is now set in stone (as registered when allocating code point in https://www.iana.org/assignments/dns-parameters/dns-parameters.xhtml) so I think it would be handy to merge this before it becomes RFC, it would allow more people to experiment with SVCB/HTTPS records and also to write tests for other DNS software using dnspython. |
|
For a variety of reasons, including all the refactoring, I did my own implementation of these. Thank you for contributing though! |
This implements the SVBC and HTTPS records as described in
https://tools.ietf.org/html/draft-ietf-dnsop-svcb-https-00
Given that the dnspython library is often used to test other
implementations, it is useful for it to implement this draft, even
though it's not finalized yet, to help with interop testing.
The wire and presentation formats for SVCB and HTTPS are identical,
so the base RD implementation is split into its own class, so that it
can be reused for all records that have the same format.
Note that this is a very early implementation of the draft. I'm publishing this code to allow others to test it (e.g. against their own implementations), but until more testing is done it's probably a good idea to keep the PR open.