-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add "react-native" key to package.json #181
Conversation
Thanks! However, I don't understand why the source works but the development build fails. I'd like to understand this fix better before applying it...what is it about the development build that react native rejects it? |
@rtfeldman Since the build files for broswers are listed in |
@jgkim ah, got it! In that case, it seems like it would make more sense to fix this by removing these from
...and then having both What do you think? |
@rtfeldman I guess the |
Yeah maybe I think since we know about |
Making it explicit is good. :) I think |
@jgkim If you make those changes above, can you rebase on top of |
dea1f1d
to
5cd2034
Compare
Thanks @jgkim! |
This resolves #180, which is related to facebook/react-native#2208.